BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

feat(ui-ux): allow dusd only vaults #4115

Closed Krysh90 closed 10 months ago

Krysh90 commented 10 months ago

What this PR does / why we need it:

Allowing DUSD looped vaults again. Previous check for taking a new DUSD loan was to have enough DFI collateral. This will change with next hardfork to either have enough DFI in collateral, or only having DUSD as collateral.

Therefore a vault with only DUSD as its collateral must be able to take a DUSD loan. This is a MUST feature to have. It MUST be released in light-wallet before the hardfork is happening. It was already communicated like this in dev-discord.

Which issue(s) does this PR fixes?:

Fixes #4034

Additional comments?:

If there are any changes missing to get in, please do them. We need to make sure to have this functionality in with next version.

Developer Checklist:

lykalabrada commented 10 months ago

Hi @Krysh90 I submitted a similar PR but missed a few things. Your PR reminded me of those omissions, so thank you for your submission! 🙏 However, we also need to update the "Add/Remove Collateral" screens to accommodate these changes.

I've updated my PR #4114, which includes the translations you added. We still need to finalize the new error messages and translations. We'd appreciate it if you could test the affected scenarios in my PR, and please do let us know if you find anything missing. Thank you!

Krysh90 commented 10 months ago

Hey @lykalabrada, I will gladly check your PR and test it locally. Then I suggest that we are closing this PR and move forward with yours.