BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

feat(ui-ux): display evm tx id and url that points to metascan #4117

Closed lykalabrada closed 9 months ago

lykalabrada commented 10 months ago

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes DFC-313

Additional comments?:

Developer Checklist:

linear[bot] commented 10 months ago

DFC-313 Task: Add EVM TX id in transfer domain transaction

github-actions[bot] commented 10 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 10 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit a4f6cc7309d656750796bfaec199b1e9814e33c8

https://expo.io/@defichain/wallet?release-channel=pr-preview-4117

codecov-commenter commented 10 months ago

Codecov Report

Merging #4117 (008ef96) into main (28a6a17) will decrease coverage by 0.06%. The diff coverage is 65.00%.

@@            Coverage Diff             @@
##             main    #4117      +/-   ##
==========================================
- Coverage   52.07%   52.01%   -0.06%     
==========================================
  Files         438      438              
  Lines       12399    12434      +35     
  Branches     4104     4116      +12     
==========================================
+ Hits         6457     6468      +11     
- Misses       5865     5884      +19     
- Partials       77       82       +5     
Files Coverage Δ
.../components/OceanInterface/TransactionIDButton.tsx 100.00% <100.00%> (ø)
...pp/components/OceanInterface/TransactionDetail.tsx 88.23% <75.00%> (+13.23%) :arrow_up:
shared/contexts/DeFiScanContext.tsx 48.33% <0.00%> (-6.06%) :arrow_down:
...p/app/components/OceanInterface/OceanInterface.tsx 67.50% <64.00%> (-1.25%) :arrow_down:

... and 55 files with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!