BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

feature(ui-ux): added get private key feature #4120

Closed fullstackninja864 closed 9 months ago

fullstackninja864 commented 9 months ago

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes DFC-384

Additional comments?:

Developer Checklist:

github-actions[bot] commented 9 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 9 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit 42b04a8bbc6075e164b74713d035793ab5c18188

https://expo.io/@defichain/wallet?release-channel=pr-preview-4120

codecov-commenter commented 9 months ago

Codecov Report

Merging #4120 (6912410) into main (9b52cb0) will increase coverage by 5.33%. The diff coverage is 55.00%.

@@            Coverage Diff             @@
##             main    #4120      +/-   ##
==========================================
+ Coverage   56.06%   61.40%   +5.33%     
==========================================
  Files         438      438              
  Lines       12353    12396      +43     
  Branches     4090     4103      +13     
==========================================
+ Hits         6926     7612     +686     
+ Misses       5343     4693     -650     
- Partials       84       91       +7     
Files Coverage Δ
...ortfolio/components/BottomSheetAddressDetailV2.tsx 90.09% <ø> (+88.33%) :arrow_up:
...nsactionAuthorization/TransactionAuthorization.tsx 78.72% <100.00%> (+3.32%) :arrow_up:
...tfolio/components/CreateOrEditAddressLabelForm.tsx 69.67% <51.78%> (+68.37%) :arrow_up:

... and 27 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

chloezxyy commented 9 months ago

LGTM, just the lint issue to fix

linear[bot] commented 9 months ago
DFC-384 Allow user to export 0x address private key in Light Wallet

**Summary** Currently, the only way for a user to participate in MetaChain is to * TransferDomain via Convert flow in the Light Wallet * Send TD-ed asset from 0x address in LW to another 0x address in 3rd party wallet(s) * Use 3rd party wallet(s) with custom network to connect to MetaChain **Requirements** The user should be able to ***export***** their *Private Key of their 0x Address in Light Wallet*** Which they can now import the same Private Key into 3rd party wallet(s). The entry point to export their PK can be via > ~Settings > Address Book > Your Address >~ Portfolio (EVM) > EVM Address > EVM Address Details > Export Private Key > Passcode/Verification > Show Private Key (String) Utilizing the Jellyfish SDK, ``` (await account.privateKey()).toString("hex") ``` To extract the Private Key of an account.