Open chloezxyy opened 9 months ago
The following translations are missing for this pull request.
{
"missingLanguageItems": {
"zh-Hans": {
"missingCount": 0,
"labels": {},
"totalCount": 2033,
"allLabels": "{}"
},
"zh-Hant": {
"missingCount": 0,
"labels": {},
"totalCount": 2033,
"allLabels": "{}"
},
"fr": {
"missingCount": 0,
"labels": {},
"totalCount": 2033,
"allLabels": "{}"
},
"es": {
"missingCount": 0,
"labels": {},
"totalCount": 2033,
"allLabels": "{}"
},
"it": {
"missingCount": 0,
"labels": {},
"totalCount": 2033,
"allLabels": "{}"
}
},
"totalMissingCount": 0
}
Build preview for DeFiChain Wallet is ready!
Built with commit 7695d89fe8430c731041dd93e1fb4cc2a84498f8
https://expo.io/@defichain/wallet?release-channel=pr-preview-4121
Merging #4121 (c344e88) into main (9b52cb0) will decrease coverage by
1.50%
. The diff coverage is52.94%
.
@@ Coverage Diff @@
## main #4121 +/- ##
==========================================
- Coverage 56.06% 54.56% -1.50%
==========================================
Files 438 438
Lines 12353 12364 +11
Branches 4090 4101 +11
==========================================
- Hits 6926 6747 -179
- Misses 5343 5534 +191
+ Partials 84 83 -1
Files | Coverage Δ | |
---|---|---|
...igator/screens/Portfolio/components/AddressRow.tsx | 73.26% <33.33%> (ø) |
|
...Navigator/screens/Portfolio/screens/SendScreen.tsx | 63.82% <57.14%> (-1.71%) |
:arrow_down: |
... and 27 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
#### What happened? 1. Verified is displayed instead of "Verified Defichain (DVM) address"in Send screen 2. Disclaimer " You are sending assets to a DFI address. EVM asset gets converted to DVM. Learn more" is missing Issue 2 happens for EVM → DVM & DVM → EVM. Fix required for both flows. #### "What did you expect to happen? [https://www.figma.com/file/2R0O9elwIN3fkkBnxLsUMM/Mobile-Light-Wallet---Handover-File?type=design&node-id=14331-178952&mode=design&t=eNiZ6gRY2hAwhYTW-4](https://www.figma.com/file/2R0O9elwIN3fkkBnxLsUMM/Mobile-Light-Wallet---Handover-File?type=design&node-id=14331-178952&mode=design&t=eNiZ6gRY2hAwhYTW-4) #### How to reproduce it (as minimally and precisely as possible): 1. User is in EVM network 2. User clicks on send quick link 3. Selects token and scans QR code for DVM address [Verified_DVM_Address_Expected.jpeg](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/ec5a2418-a737-42ee-8ddb-0e46e86cf070/09f18c92-bfbf-49b4-993a-e41aa7432192) #### Anything else that the team needs to know?
What this PR does / why we need it:
Which issue(s) does this PR fixes?:
Fixes DFC-380
Additional comments?:
Learn more
button is excluded since info page is not up.Developer Checklist: