BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

fix(ui-ux): fixed convert screen issue for evm domain #4122

Closed fullstackninja864 closed 9 months ago

fullstackninja864 commented 9 months ago

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes DFC-401

Additional comments?:

Developer Checklist:

github-actions[bot] commented 9 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2029,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2029,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2029,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2029,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2029,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
linear[bot] commented 9 months ago
DFC-401 Should not able to change to address in evm domain while converting tokens

[image.png](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/1abba8ef-70b3-4cf4-9169-26f3b53d2902/2c0a3feb-2c79-4b45-bdfe-1089d91444be)

github-actions[bot] commented 9 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit ba6dd92c4678e1ffdd5dd2beee5fa00f2d66fe86

https://expo.io/@defichain/wallet?release-channel=pr-preview-4122

codecov-commenter commented 9 months ago

Codecov Report

Merging #4122 (f8f4ff6) into main (9b52cb0) will decrease coverage by 2.23%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #4122      +/-   ##
==========================================
- Coverage   56.06%   53.83%   -2.23%     
==========================================
  Files         438      438              
  Lines       12353    12357       +4     
  Branches     4090     4093       +3     
==========================================
- Hits         6926     6653     -273     
- Misses       5343     5622     +279     
+ Partials       84       82       -2     
Files Coverage Δ
...igator/screens/Portfolio/screens/ConvertScreen.tsx 51.58% <50.00%> (+0.89%) :arrow_up:

... and 12 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more