BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

fix(ui-ux): address book details screen #4123

Open chloezxyy opened 9 months ago

chloezxyy commented 9 months ago

What this PR does / why we need it:

Based on this slack convo: https://cakedefi.slack.com/archives/C05P409R1HQ/p1698891566588349

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

github-actions[bot] commented 9 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2038,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 9 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit 7f9405fd344ec4a6e5d1906bb69d3ef1a288f9d2

https://expo.io/@defichain/wallet?release-channel=pr-preview-4123

codecov-commenter commented 9 months ago

Codecov Report

Merging #4123 (0127030) into main (d61a44b) will decrease coverage by 4.47%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4123      +/-   ##
==========================================
- Coverage   56.06%   51.60%   -4.47%     
==========================================
  Files         438      438              
  Lines       12353    12356       +3     
  Branches     4090     4092       +2     
==========================================
- Hits         6926     6376     -550     
- Misses       5343     5899     +556     
+ Partials       84       81       -3     
Files Coverage Δ
...or/screens/Portfolio/screens/AddressBookScreen.tsx 0.00% <0.00%> (ø)

... and 53 files with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!