BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

feat(ui-ux): allow 100% dusd vault to borrow non-dusd tokens #4129

Closed lykalabrada closed 9 months ago

lykalabrada commented 9 months ago

What this PR does / why we need it:

Allow borrowing of dTokens when vault has 100% DUSD collateral

To borrow DUSD token:

To borrow non-DUSD tokens:

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

github-actions[bot] commented 9 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2032,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2032,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2032,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2032,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2032,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 9 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit d349b7aba0786b4d34b1e0e3d25dda16bdebb569

https://expo.io/@defichain/wallet?release-channel=pr-preview-4129

codecov-commenter commented 9 months ago

Codecov Report

Merging #4129 (f93baf5) into main (d61a44b) will increase coverage by 3.16%. The diff coverage is 11.11%.

@@            Coverage Diff             @@
##             main    #4129      +/-   ##
==========================================
+ Coverage   56.07%   59.24%   +3.16%     
==========================================
  Files         438      438              
  Lines       12353    12356       +3     
  Branches     4090     4091       +1     
==========================================
+ Hits         6927     7320     +393     
+ Misses       5342     4949     -393     
- Partials       84       87       +3     
Files Coverage Δ
...r/screens/Loans/hooks/ValidateLoanAndCollateral.ts 94.73% <100.00%> (-0.27%) :arrow_down:
...eens/Loans/screens/AddOrRemoveCollateralScreen.tsx 54.95% <0.00%> (-1.47%) :arrow_down:

... and 48 files with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!