BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

fix(ui-ux): allow adding of dusd collateral with active dusd loan #4131

Closed lykalabrada closed 9 months ago

lykalabrada commented 9 months ago

What this PR does / why we need it:

Allow adding of DUSD collateral to a vault with active DUSD loan

To borrow DUSD token:

To borrow non-DUSD tokens:

When adding collateral:

Which issue(s) does this PR fixes?:

Fixes #4130

Additional comments?:

Developer Checklist:

github-actions[bot] commented 9 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2032,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2032,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2032,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2032,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2032,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 9 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit cb71075c263d40a98ad97e3860d1830feb9bc083

https://expo.io/@defichain/wallet?release-channel=pr-preview-4131

codecov-commenter commented 9 months ago

Codecov Report

Merging #4131 (0d8cec3) into main (f29a056) will decrease coverage by 6.10%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4131      +/-   ##
==========================================
- Coverage   61.38%   55.28%   -6.10%     
==========================================
  Files         438      438              
  Lines       12356    12348       -8     
  Branches     4091     4085       -6     
==========================================
- Hits         7585     6827     -758     
- Misses       4680     5438     +758     
+ Partials       91       83       -8     
Files Coverage Δ
...eens/Loans/screens/AddOrRemoveCollateralScreen.tsx 57.00% <0.00%> (+2.05%) :arrow_up:

... and 47 files with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!