BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
126 stars 46 forks source link

fix(ui-ux): cfp valid address warning #4150

Closed pierregee closed 7 months ago

pierregee commented 7 months ago

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

github-actions[bot] commented 7 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 7 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit 54ae04c3e058dcd19ca4927a8f96b45b40392052

https://expo.io/@defichain/wallet?release-channel=pr-preview-4150

codecov-commenter commented 7 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7dd1836) 61.48% compared to head (dfdf0c3) 61.44%.

Files Patch % Lines
...igator/screens/Portfolio/components/AddressRow.tsx 33.33% 2 Missing :warning:
.../screens/Portfolio/screens/OCG/CFPDetailScreen.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4150 +/- ## ========================================== - Coverage 61.48% 61.44% -0.05% ========================================== Files 438 438 Lines 12469 12473 +4 Branches 4127 4128 +1 ========================================== - Hits 7667 7664 -3 - Misses 4711 4718 +7 Partials 91 91 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.