BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
126 stars 46 forks source link

fix(ui-ux): hide send btn for evm domain #4153

Closed fullstackninja864 closed 7 months ago

fullstackninja864 commented 7 months ago

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes DFC-429

Additional comments?:

Developer Checklist:

linear[bot] commented 7 months ago

DFC-429 [UX] Disable "Send" button on LW EVM.

github-actions[bot] commented 7 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2042,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 7 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit 05230de411670930edd61a0c3de92ee99642aabc

https://expo.io/@defichain/wallet?release-channel=pr-preview-4153

codecov-commenter commented 7 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (3fbff35) 61.46% compared to head (e6587e8) 55.36%.

Files Patch % Lines
...tor/screens/Portfolio/components/ActionButtons.tsx 44.44% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4153 +/- ## ========================================== - Coverage 61.46% 55.36% -6.10% ========================================== Files 438 438 Lines 12473 12482 +9 Branches 4128 4134 +6 ========================================== - Hits 7666 6911 -755 - Misses 4715 5484 +769 + Partials 92 87 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.