search

BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
126 stars 46 forks source link

Can not set slipage above 100% #4170

Closed kuegi closed 4 months ago

kuegi commented 4 months ago

With the upcoming fee change (up to 80% fee on DUSD sells), the current LW behaviour will prevent any DUSD->crypto swaps.

The slipage in the LW is used as maxPrice= expectedPrice*(1+slipage). Since the fee is removed before the swap even happens, a 80% fee means the resulting price is 400% worse in the above definition (1/(1-0.8) = 5).

Unfortunately the LW only allows to enter a slipage between 0 and 100%. So any fee above 50% leads to LW users no longer being able to swap.

github-actions[bot] commented 4 months ago

@kuegi: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details I am a bot created to help the [BirthdayResearch](https://github.com/BirthdayResearch) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/BirthdayResearch/defichain-wallet/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
github-actions[bot] commented 4 months ago

@kuegi: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details I am a bot created to help the [BirthdayResearch](https://github.com/BirthdayResearch) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/BirthdayResearch/defichain-wallet/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
github-actions[bot] commented 4 months ago

@kuegi: Thanks for opening an issue, an appropriate priority will be added soon.

The priority labels can be added by foundation members by writing /priority [type] in a comment.

Details I am a bot created to help the [BirthdayResearch](https://github.com/BirthdayResearch) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/BirthdayResearch/defichain-wallet/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
fullstackninja864 commented 4 months ago

Hi @kuegi , Current range for custom input in LW is 0-100% (more than zero). What range you are suggesting to get this issue fixed?

kuegi commented 4 months ago

Hi @kuegi , Current range for custom input in LW is 0-100% (more than zero). What range you are suggesting to get this issue fixed?

do you have to set an upper limit? for it to work with the 80% fee, it needs to be set > 400%. But why not just remove the limitation completely? slipage must be > 0, but thats it, right?