BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

`Desktop mode` #746

Open thedoublejay opened 3 years ago

thedoublejay commented 3 years ago

What would you like to be added:

We would like to have a light wallet desktop app that can be installed on Windows, Mac and Linux. Light wallet means it doesn't need to run a full node (like our existing desktop wallet) but use APIs from whale to do transactions. As a first iteration, we will only support light mode but in the future we can have a full node version as well.

It should share state and architecture with the mobile app. The only difference would be in terms of UI state. While there are solutions out there to provide easier portability between mobile and desktop, it might cause more harm in the future. Features not existing, lots of hacks and gotcha to add (if desktop, if mobile etc.).

Acceptance Criteria:

Setup and Workflows

Features

defichain-bot commented 3 years ago

@thedoublejay: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/wallet/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
defichain-bot commented 3 years ago

@thedoublejay: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/wallet/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
thedoublejay commented 3 years ago

@jtlntno-cake We would also want to put some disclaimer/copy on some parts of the app that it's a light wallet and there are differences between the full node wallet. Like:

jtlntno-des commented 3 years ago

@thedoublejay here's a rough initial design for our responsive grid in desktop light wallet. As it stands, we have the minimum size of 768px (to cater for tablet-portrait) but we can have the default size as 1024px.

With this, we can start laying out the components as what we have from the mobile light wallet.

Let me know your thoughts or add comments on Figma.