search

BirthdayResearch / defiscan.live

DeFi Scan, everything one-stop location for DeFi Blockchain. Powered by jellyfish & ocean network.
https://defiscan.live
MIT License
45 stars 17 forks source link

Bring back Token icons #598

Closed 0ptim closed 2 years ago

0ptim commented 2 years ago

What would you like to be added:

Icons for all kind of tokens should be implemented again. Mentioned in PR #586, we don't have the rights to use these icons and other brokerage platforms don't display them.

Maybe I'm missing something here, but why is Trading212 able to display all these icons?

Why is this needed:

UX will be improved and UI looks friendlier.

defichain-bot commented 2 years ago

@0ptim: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/scan/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
defichain-bot commented 2 years ago

@0ptim: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/scan/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
ngyingzhong commented 2 years ago

Thanks for the question @0ptim! We can't speak for other platforms but as you rightly pointed out, copyright is the main reason token icons are not displayed. That said, the team is working on a workaround to strike a balance between such technical issues and user experience.

0ptim commented 2 years ago

Good to know. I think this kind of details can make a big difference for new users visiting the site. I hope there will be a way. If you wish, I can try to get in contact with these platforms, to maybe get some more information about this.

0ptim commented 2 years ago

Reporting back here.

Regarding our problem, I made a post on the official Trading 212 community forum. (I know that they are using these icons, because I'm actively using their App to manage my stock portfolio.)

According to the answers there, the usage of the logos on the T212 platform falls under the fair-use-policy.

I've found more information regarding this here and here.

What do you guys think of this? Is there any lawyer which you guys are in contact with?

I'll continue investigating in the meantime.

ngyingzhong commented 2 years ago

Hey @0ptim, awesome work and very insightful reply from Trading 212, thanks for researching 🙏 We understand that having the logos will improve user experience, thus we've had several discussions around this issue in the past week which we would like to share.

The key thing to clarify is the difference between Trading 212 (T212) and DeFiChain. While T212 is an online brokerage dealing with securities in the TradFi market, DeFiChain is a decentralized ecosystem providing DeFi services. In that regard, a user is able to access financial products that are offered in stock exchanges on T212, but he/she won't be able to do the same on DeFiChain. The Decentralized Loan feature on DFC, for example, provides access to loan tokens via decentralized tokenization which effectively allows users to mint loan tokens (e.g. dTSLA). The prices of these loan tokens (at the point of loan and payback) are provided by oracles, but beyond that have no relations with the public financial market. The value of these decentralized loan tokens are hence determined by the supply and demand on DeFiChain's DEX. As a result, it will be inaccurate to associate the the loan tokens with the actual world asset via the brand logos.

That said, the platform seeks to place user experience at the forefront, and will continue to experiment to find a balance between usability and representation. Will provide an update the soonest possible!

ngyingzhong commented 2 years ago

Hi @0ptim, as a follow-up to our conversation, we have implemented the new token design on DeFi Scan and on the latest Light Wallet app release. Thanks for following along, I will be closing the issue for now 🥇