search

BirthdayResearch / jellyfishsdk

DeFiChain Jellyfish SDK & Ecosystem for building modern lite DeFi Applications at scale.
https://jellyfishsdk.com
MIT License
104 stars 36 forks source link

chore(): support whale test suite for defid ocean #2174

Closed canonbrother closed 9 months ago

canonbrother commented 11 months ago

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Allow ocean test-suites running on Defid Its tricky to map Defid Ocean API and function with Whale Ocean eg:

if (app instanceof DefidBin) {
      controller = app.addressController
} else {
      controller = app.get(AddressController)
}

Sinonjs-like is an ideal approach

Additional comments?:

netlify[bot] commented 11 months ago

Deploy Preview for jellyfishsdk ready!

Name Link
Latest commit 1819b10279206cc4e0f839c09cf47b6a850af5a3
Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/65b23b3be5c2d50008b7a7fd
Deploy Preview https://deploy-preview-2174--jellyfishsdk.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 289 lines in your changes are missing coverage. Please review.

Comparison is base (e04c2b0) 91.84% compared to head (1819b10) 65.27%.

Files Patch % Lines
apps/whale-api/src/e2e.defid.module.ts 8.41% 257 Missing and 26 partials :warning:
apps/whale-api/src/e2e.module.ts 62.50% 5 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2174 +/- ## =========================================== - Coverage 91.84% 65.27% -26.57% =========================================== Files 374 357 -17 Lines 11301 11360 +59 Branches 1477 1527 +50 =========================================== - Hits 10379 7415 -2964 - Misses 891 3713 +2822 - Partials 31 232 +201 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 10 months ago

Docker build preview for jellyfish/apps is ready!

Built with commit 820dc27b1b89c7db49bc1dff4c709dd9aa3230c9

You can also get an immutable image with the commit hash

canonbrother commented 9 months ago

refer to https://github.com/BirthdayResearch/jellyfishsdk/pull/2177