search

BirthdayResearch / jellyfishsdk

DeFiChain Jellyfish SDK & Ecosystem for building modern lite DeFi Applications at scale.
https://jellyfishsdk.com
MIT License
106 stars 35 forks source link

`jellyfish-transaction-signature`: support p2sh / p2pkh #384

Open ivan-zynesis opened 3 years ago

ivan-zynesis commented 3 years ago

What would you like to be added:

Why is this needed:

Todo:

defichain-bot commented 3 years ago

@ivan-zynesis: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/jellyfish/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
defichain-bot commented 3 years ago

@ivan-zynesis: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/jellyfish/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
ivan-zynesis commented 3 years ago

/area jellyfish-transaction-signature

fuxingloh commented 3 years ago

/triage accepted /assign @ivan-zynesis

Prioritize the more commonly used address types, break down the PR as much as you can.

For the technical details:

  1. caller provide redeem script, you might want to make this option available for all. When a redeem script isn't provided and it cannot be guessed, we can throw an exception. Alternatively, you can change the technical design for better simplicity such that if you can't provide a redeem script, we can't and don't attempt to solve it.
  2. most of the code that has been written can be shared with other types. You might want to refactor into the code pattern that you plan to organize the code first before you start working on the issue.
  3. try to minimize code branching for this, as much as possible.