search

BirthdayResearch / jellyfishsdk

DeFiChain Jellyfish SDK & Ecosystem for building modern lite DeFi Applications at scale.
https://jellyfishsdk.com
MIT License
104 stars 36 forks source link

`PoolPairInfo.customRewards` is nullable? #393

Closed fuxingloh closed 3 years ago

fuxingloh commented 3 years ago

What happened:

PoolPairInfo.customRewards appears to be optional when testing in DeFiCh/whale, but they are not optional in jellyfish?

/area jellyfish-api-core /triage accepted /priority urgent-now /assign @canonbrother to investigate this, thanks

canonbrother commented 3 years ago

Yes poolpair.customeRewards should be nullable https://github.com/DeFiCh/ain/blob/7a430185fd3029e9ee8974fde4e65c715fb9db04/src/masternodes/rpc_poolpair.cpp#L51-L59