DeFi Blockchain RPC Implementations

[fuxingloh]

This tracks all the RPC methods and categories being implemented in jellyfish-api-core. Will list all the methods here, and strike out those that are not applicable.

Feel free to update this and tag yourself if you want to work on a feature. You will need to reference DeFiCh/ain code base, https://github.com/DeFiCh/ain/tree/master/src/rpc to be exact.

This is purely for documenting all features of DeFi Blockchain. 
Everything that is required has already been completed.

src/rpc

blockchain.cpp

• [x] getblockchaininfo #89
• [x] getchaintxstats #1051
• [x] getblockstats #256
• [x] getbestblockhash #256
• [x] getblockcount #91
• [x] getblock #91
• [x] getblockhash #91
• [x] getblockheader #163
• [x] getchaintips #205
• [x] getdifficulty #285
• [x] getmempoolancestors
• [x] getmempooldescendants #1796
• [x] getmempoolentry
• [x] getmempoolinfo #364
• [x] clearmempool #1801
• [x] getrawmempool #112
• [x] gettxout #94
• [x] gettxoutsetinfo
• [ ] pruneblockchain
• [ ] savemempool
• [ ] verifychain #952
• [ ] preciousblock
• [ ] scantxoutset
• [ ] getblockfilter
• [ ] invalidateblock #1904
• [ ] reconsiderblock #1904
• [x] waitfornewblock #807
• [x] waitforblock #1805
• [x] waitforblockheight #807
• [ ] syncwithvalidationinterfacequeue

mining.ccp

• [x] getnetworkhashps #41
• [x] getmintinginfo #41 deprecated
• [x] getmininginfo #229
• [ ] prioritisetransaction
• [ ] getblocktemplate - cedric
• [ ] submitblock #1980
• [ ] submitheader
• [x] generatetoaddress (regtest only)
• [x] estimatesmartfee #254
• [x] estimaterawfee deprecated

misc.cpp

• [x] getmemoryinfo (utils only)
• [x] logging (utils only)
• [x] validateaddress #112
• [ ] createmultisig #1977
• [ ] deriveaddresses #1974
• [x] getdescriptorinfo (utils only)
• [x] verifymessage #1905
• [ ] signmessagewithprivkey #1905
• [x] setmocktime (testing only)
• [x] setmockcheckpoint (testing only)
• [x] echo (testing only)
• [x] echojson (testing only)

net.cpp

• [x] getconnectioncount #176
• [ ] ping
• [x] getpeerinfo #938
• [ ] addnode
• [ ] disconnectnode
• [ ] getaddednodeinfo
• [x] getnettotals - #1843
• [x] getnetworkinfo #180
• [ ] setban
• [ ] listbanned
• [ ] clearbanned
• [ ] setnetworkactive
• [ ] getnodeaddresses

rawtransaction.cpp

• [x] getrawtransaction #385
• [x] createrawtransaction #127
• [x] decoderawtransaction #1963
• [ ] decodescript - shana
• [x] sendrawtransaction #127
• [ ] combinerawtransaction
• [x] signrawtransactionwithkey #127
• [x] testmempoolaccept #127
• [ ] decodepsbt
• [ ] combinepsbt
• [ ] finalizepsbt
• [ ] createpsbt
• [ ] converttopsbt
• [ ] utxoupdatepsbt
• [ ] analyzepsbt
• [ ] joinpsbts
• [ ] gettxoutproof
• [ ] verifytxoutproof

### `server.cpp` - COMPLETED

- [x] getrpcinfo #330 - [x] ~~help~~ - [x] ~~stop~~ - [x] uptime #340

src/spv

spv_rpc.cpp

• [ ] spv_sendrawtx
• [ ] spv_createanchor
• [ ] spv_createanchortemplate
• [ ] spv_estimateanchorcost
• [ ] spv_rescan
• [ ] spv_syncstatus
• [ ] spv_gettxconfirmations
• [ ] spv_splitutxo
• [x] spv_listanchors #618
• [x] spv_listanchorauths #618
• [x] spv_listanchorrewardconfirms #620
• [x] spv_listanchorrewards #620
• [x] spv_listanchorsunrewarded #620
• [x] spv_listanchorspending #618
• [x] spv_setlastheight #618
• [ ] spv_getfeerate

src/wallet

rpcwallet.cpp

• [ ] fundrawtransaction
• [ ] abandontransaction
• [ ] abortrescan
• [ ] addmultisigaddress
• [ ] backupwallet
• [ ] bumpfee
• [x] createwallet #112
• [x] dumpprivkey #306
• [ ] dumpwallet
• [ ] encryptwallet
• [ ] getaddressesbylabel
• [x] getaddressinfo #112
• [x] getbalance #41
• [x] getnewaddress #112
• [ ] getrawchangeaddress
• [ ] getreceivedbyaddress
• [ ] getreceivedbylabel
• [x] gettransaction #342
• [x] getunconfirmedbalance #354
• [x] getbalances #362
• [x] getwalletinfo #112
• [ ] importaddress
• [ ] importmulti
• [x] importprivkey #306
• [ ] importprunedfunds
• [ ] importpubkey
• [ ] importwallet
• [ ] keypoolrefill
• [x] listaddressgroupings #112
• [ ] listlabels
• [ ] listlockunspent
• [ ] listreceivedbyaddress
• [ ] listreceivedbylabel
• [ ] listsinceblock
• [ ] listtransactions
• [x] listunspent #94
• [ ] listwalletdir
• [x] listwallets #953
• [ ] loadwallet #1931
• [ ] lockunspent
• [ ] removeprunedfunds
• [ ] rescanblockchain
• [x] sendmany #269
• [x] sendtoaddress #112
• [ ] sethdseed
• [ ] setlabel
• [ ] settxfee
• [x] setwalletflag #112
• [x] signmessage #1934
• [ ] signrawtransactionwithwallet
• [ ] unloadwallet
• [ ] walletcreatefundedpsbt
• [ ] walletlock
• [ ] walletpassphrase
• [ ] walletpassphrasechange
• [ ] walletprocesspsbt

## `src/masternode`

### `mn_rpc.cpp` - COMPLETED

- [x] setgov #456 - [x] getgov #456

### `rpc_accounts.cpp` - COMPLETED

- [x] listaccounts #162 - [x] getaccount #162 - [x] gettokenbalances #162 - [x] utxostoaccount #215 - [x] accounttoaccount #284 - [x] accounttoutxos #289 - [x] listaccounthistory #162 - [x] accounthistorycount #265 - [x] listcommunitybalances #368 - [x] sendtokenstoaddress #323 - [x] listburnhistory #444 - [x] getburninfo #540

### `rpc_masternodes.cpp` - COMPLETED

- [x] createmasternode #372 - [x] resignmasternode #419 - [x] updatemasternode #1847 - [x] listmasternodes #372 - [x] getmasternode #372 - [x] getmasternodeblocks #861 - [x] ~~listcriminalproofs~~ deprecated - [x] getanchorteams #923 - [x] getactivemasternodecount #648 - [x] listanchors #921 - [x] isappliedcustomtx #957

### `rpc_poolpair.cpp` - COMPLETED

- [x] listpoolpairs #121 - [x] getpoolpair #121 - [x] addpoolliquidity #121 - [x] removepoolliquidity #420 - [x] createpoolpair #121 - [x] updatepoolpair #1958 - [x] poolswap #413 - [x] listpoolshares #121 - [x] testpoolswap #411

### `rpc_tokens.cpp` - COMPLETED

- [x] createtoken #120 - [x] updatetoken #120 - [x] listtokens #120 - [x] gettoken #120 - [x] getcustomtx #1878 - [x] minttokens #290 - [x] decodecustomtx #1878

[fuxingloh]

Working on blockchain.cpp

1. getblockchaininfo

[canonbrother]

Working on blockchain.cpp

1. getblock
2. getblockhash
3. getblockcount

[canonbrother]

Working on blockhain.cpp

1. gettxxout

[fuxingloh]

Will be working on various rawtransaction.cpp rpc for wallet integration.

1. getrawtransaction
2. createrawtransaction
3. decoderawtransaction
4. decodescript
5. sendrawtransaction
6. combinerawtransaction
7. signrawtransactionwithkey

[fuxingloh]

Updated RPC typing prioritization, removed prioritization for RPC that are going to be created with jellyfish-transaction.

All RPC without side effect/mutating properties (get, list) should be prioritized over those with side effect (create, update)

[fuxingloh]

To prioritize:

rpc_tokens.cpp

• listtokens
• gettoken

rpc_poolpair.cpp

• listpoolpairs
• getpoolpair
• listpoolshares

rpc_accounts.cpp

• listaccounts
• getaccount
• gettokenbalances
• listaccounthistory

mining.ccp

• estimatesmartfee
• estimaterawfee

[canonbrother]

Working on (late update, DONE) blockhain.cpp

1. getrawmempool

wallet.cpp

1. wallet.getNewAddress
2. wallet.getAddressInfo
3. wallet.validateAddress
4. wallet.listAddressGroupings
5. wallet.getWalletInfo
6. wallet.setWalletFlag
7. wallet.sendToAddress
8. wallet.createWallet

[canonbrother]

Working on rpc_tokens.cpp (improving tests)

1. listokens
2. gettoken
3. createtoken
4. updatetoken

[canonbrother]

Working on rpc_poolpair.cpp (improving tests)

1. listPoolPairs
2. getPoolPair
3. listPoolShares
4. createPoolPair
5. addPoolLiquidity

[canonbrother]

Working rpc_accounts.cpp

1. listaccounts
2. getaccount
3. gettokenbalances
4. listaccounthistory

[jingyi2811]

Working on net.cpp

getconnectioncount getpeerinfo getnetworkinfo

[fuxingloh]

@jingyi2811 mentioned that it's hard to test multi node setup (e.g. getpeerinfo) without https://github.com/DeFiCh/jellyfish/issues/40 implemented. Hence some RPC implementations are blocked by that.

[jingyi2811]

Working on blockchain.cpp

getchaintips

[fuxingloh]

Please priotize in this order:

1. rpc_accounts.cpp
2. rpc_tokens.cpp
3. rpc_accounts.cpp

[jingyi2811]

Working on rpc_accounts.cpp

utxostoaccount (Done) accounttoaccount (Done) accounttoutxos (Done)

[jingyi2811]

Working on rpc_tokens.cpp

getcustomtx (Put this aside as this rpc requires docker networking to be enabled) minttokens (Done)