BirthdayResearch / jellyfishsdk

DeFiChain Jellyfish SDK & Ecosystem for building modern lite DeFi Applications at scale.
https://jellyfishsdk.com
MIT License
104 stars 36 forks source link

`setLoanToken` rpc ~mintable:false~ #833

Closed canonbrother closed 2 years ago

canonbrother commented 2 years ago

What happened:

Loan token is not allowed to be minted. It should back by vault.

What you expected to happen:

loanToken.mintable: false

How to reproduce it (as minimally and precisely as possible):

https://github.com/DeFiCh/jellyfish/blob/7fd90034696d4343ca6ba5f34834df7ee8267ed7/packages/jellyfish-api-core/src/category/loan.ts#L147-L149

Anything else we need to know?:

https://github.com/DeFiCh/ain/blob/2baae1d961a72640cc1950bbaecc9b9537dbd521/src/masternodes/mn_checks.cpp#L694-L698

defichain-bot commented 2 years ago

@canonbrother: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/jellyfish/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
defichain-bot commented 2 years ago

@canonbrother: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/jellyfish/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.