search

BirthdayResearch / jellyfishsdk

DeFiChain Jellyfish SDK & Ecosystem for building modern lite DeFi Applications at scale.
https://jellyfishsdk.com
MIT License
104 stars 36 forks source link

`packages/jellyfish-testing`: Add support to accept `RegTestContainer` in `Testing` #965

Closed surangap closed 1 year ago

surangap commented 2 years ago

What would you like to be added:

check the possibility of accepting a RegTestContainer instead of MasterNodeRegTestContainer in Testing class.

Why is this needed:

there can be tests that specifically require non-masternodes.

defichain-bot commented 2 years ago

@surangap: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/jellyfish/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
defichain-bot commented 2 years ago

@surangap: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/jellyfish/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
kodemon commented 2 years ago

I have a small draft branch on this issue which I am tinkering with, will put up as a draft PR once I have a better proof of concept.

For the single test container its relatively simple to set up inference based on the testingcontainer used in the create method. The tricky part is the TestingGroup which can potentially have any type of containers assigned, unless we lock the container type for each group (which I don't think is what we want?).

fuxingloh commented 2 years ago

/assign @kodemon /triage accepted /area packages