Bisa / factorio-init

Factorio init script
MIT License
414 stars 82 forks source link

further FIFO issues #206

Open tmzasz opened 9 months ago

tmzasz commented 9 months ago

After a forced system update to Ubuntu it would appear that the script hangs during the closing of the FIFO step when issuing the stop command. Closer examination of the code shows that the fifo itself is the root process and spawns the process killed with the pid in server.pid

as_user "tail -f ${FIFO} |${INVOCATION} ${EXE_ARGS_GLIBC}>> ${CMDOUT} 2>&1 & echo \$! > ${PIDFILE}"

When this is killed on the most recent Ubuntu lts 22.04 the stop command kills the server and the FIFO dies with it. I believe this might be the issue you were referring to Bisa in my previous fix for #185 . However I notice in this case you can either restore the cat ${FIFO} & line ( which causes runaway cats on some systems )or just comment out the entire extra FIFO block and it functions normally (closes out and dosent hang or runaway.

https://github.com/Bisa/factorio-init/blob/94e949999b680946c0f7f6828bb98da607a4ca1a/factorio#L361C5-L366C14

on this im unsure how to correct this as this is now 3 different behaviors for this and my previous fix may need to be reverted and a OS dependent solution devised.