search

Bisa / factorio-init

Factorio init script
MIT License
415 stars 82 forks source link

Use $FACTORIO_PATH in config example #61

Closed jakimfett closed 8 years ago

jakimfett commented 8 years ago

By default, the config.ini file is generated in a folder named "config" two directory levels above the factorio binary. This means that by default, the config.ini file is at ${FACTORIO_PATH}/config/config.ini.

Changing this in the config.example factorio-init configuration files means less for the end user to change when setting up factorio-init.

Bisa commented 8 years ago

I'm going to have to reject this as it prevents using the same config file for systemd, see previous pr https://github.com/Bisa/factorio-init/pull/38

Bisa commented 8 years ago

That said, since "config.example" and "config" are two different files and only config.example is under version control, nothing stops the user from making this change in his/her own config provided they do not use systemd to load that config

jakimfett commented 8 years ago

I'll do some more testing on a systemd system to see if I can come up with a workaround...I'm curious why it works for the BINARY variable and not the FCONF variable. Any chance you could provide some insight on this, @Bisa?

Bisa commented 8 years ago

That's because the binary variable itself is never called from the service.example, you have to specify the binary within the service file without referencing variables.

I'm starting to think the better option here would be to simply go with yours and others suggestions - ppl using systemd will need to modify it to match any way, might as well make one of the configs easier to use

jakimfett commented 8 years ago

If you want to do that, it would indeed make it easier...although I'd want to add a line like "Uncomment this if you're using systemd" to my patch, if you're going to merge it before I have time to poke the variable thing.

I'm pretty busy with IRL work at the moment (today and tomorrow are deployment days), but should have time "Soon™" to spin up a couple of systemd/upstart/sysvinit systems and see if I can hack together a solution that works on all of them.