Biscoint / biscoint-api-node

NodeJS library for interacting with biscoint.io's API.
MIT License
15 stars 7 forks source link

Fix ITradesResult:date type #28

Closed lzkill closed 2 years ago

thiagosouza commented 2 years ago

hi Mr Kill. this PR may not make sense, since the data returned it is a String in fact. We're not returning any object.

for this to happen you still have to convert the string to Date like this:

new Date(tradesResult.date)

what do you think?

lzkill commented 2 years ago

You are absolutely right, there's no reason to such a change. I'm closing this...

Sorry for the inconvenience...