search

BiscuitDevelopment / SkyblockAddons

A Minecraft Forge mod with helpful Hypixel skyblock features!
Other
483 stars 234 forks source link

[Bug] Dungeon death counter sometimes misses deaths #413

Open ILikePlayingGames opened 4 years ago

ILikePlayingGames commented 4 years ago

Please note that we do not provide support for clients other than Forge. We will not fix compatibility issues with other clients.

Describe the bug For some reason, death messages aren't shown for every death in dungeons. Since the death counter uses death messages to detect deaths, some will be missed.

To Reproduce Steps to reproduce the behavior (how did you get this bug to occur):

  1. Play dungeons
  2. Player dies without death message in chat
  3. Death not counted

Expected behavior Death counter should count every death

Screenshots N/A

Crash Report N/A

System Information

Other Installed Mods N/A

Additional info Add any other context about the problem here.

minhperry commented 4 years ago

Possible check is to detect inventory wipe but it could trigger when player removes everything from inventory, although barely anyone would do so

RobotHanzo commented 4 years ago

After the tab list update this could be easily fixed by catching the Deaths :(X) directly, I can PR if needed

ILikePlayingGames commented 4 years ago

Oh, I didn't know it's shown in the tab list now. Thanks for the tip! I'll look into it.

iHDeveloper commented 4 years ago

After the tab list update this could be easily fixed by catching the Deaths :(X) directly, I can PR if needed

In that case, the feature can use both ways (tab, chat). If the tab is present then use it. If not then we use the chat one.

~I'm not sure if the feature doesn't detect death messages sometimes. Or, Hypixel doesn't send the death messages sometimes. We need a special debugging method to detect that.~

Sometimes, Hypixel doesn't send the death message. Cowlection is also having this issue. image Source: https://discord.com/channels/720585022624628797/729170510482767932/768101039877652500

ILikePlayingGames commented 3 years ago

I think I fixed it. Further testing will be required to confirm. The fix should be released in the next beta.

ILikePlayingGames commented 3 years ago

It seems to have regressed sometime during the past few betas. I fixed deaths not being detected when people die out of render distance again. Also the alternate counter has an issue where it doesn't detect the current player's deaths since their name is not on the scoreboard. This can be fixed by tracking using other means such as player health and invisibility/flying (planned). Hypixel sometimes does not send messages, but also sometimes sends extra messages.

image

Right now the algorithm uses the tab list stat if it's there, then the highest result out of the main (chat) and alternate (scoreboard sidebar) counters.