[Bug] Effective Health doesn't match Hypixel's Value

BiscuitDevelopment / SkyblockAddons

A Minecraft Forge mod with helpful Hypixel skyblock features!

Other

483 stars 238 forks source link

[Bug] Effective Health doesn't match Hypixel's Value #551

Open pOopNoobeTer opened 3 years ago

pOopNoobeTer commented 3 years ago

The effective health feature is higher than my actual EHP

Turn on the effective health feature and it happens.

(The dark green number at 35,870 value is the EHP) The Hypixel GUI shows a different value than the mod.

OS: Windows 10
Minecraft Version: 1.8.9
Forge Version: 11.15.1.2318
SkyblockAddons Version: 1.6.0

Other Mods:

Phoube commented 3 years ago

Hi, after looking at the bug, this seems to be an issue with Hypixel Skyblock's code not accounting for health potions in the effective hp (EHP) calculation. See below:

SBA EHP = 2346 x (1 + 1429/100) = 35870 (First picture) Hyp EHP = 2046 x (1 + 1420/100) = 31099 (Second picture)

Note that for the second equation, I used your max health instead of actual health. So this seems not to be a bug with SBA's, but rather with Hypixel's EHP.

Phoube commented 3 years ago

Actually, this seems like a good thing to leave open for reference, at least for a bit

thatweirdkaden commented 2 years ago

Is there a fix for this or nah