Closed hannibal002 closed 2 years ago
Made this PR compatible with the current 1.7 release
@ImRodry Please refrain from commenting further on my pull request as you do not seem to have sufficient experience in certain aspects of skyblock, clever phrasing or English spelling, thank you.
I’m the localization manager for SBA and you don’t get to tell me when or when not to comment on a PR. If you keep up the attitude I’m closing this PR.
I’m the localization manager for SBA and you don’t get to tell me when or when not to comment on a PR. If you keep up the attitude I’m closing this PR.
My PR has primarily new features and several small fixes, and I don't really want to not merge all the changes because of a name issue. If you can't handle criticism, you shouldn't be on the internet. If you feel better, delete this PR, but I will not continue to discuss with your childish behavior.
And to be clear about another thing: I don't care what your position is in SBA. When you can't communicate respectfully, then I don't respect you either.
Suggestions are welcome
Suggestions are welcome
If you really want to keep this stupid name, please at least add "Show" or "Display" to it
"Chore: become less of a dick"
Alright, i take it back, that was a bit rude.
Oh, also: This doesn't qualify as a chore in my opinion, you should use a different git commit message for that.
The commit message is the least relevant thing, the commits will all be squashed anyways
I'm just saying: if you're gonna nit pick, at least be right while doing so :)
guys it's called a "dominus"
"Display Dominus"
guys it's called a "dominus"
"Display Dominus"
And the other 3 stacking abilities have the name "Hydra Strike", "Arcane Vision" and "Fervor". So, what now? Add 4 separate features that you have to select manually? Or just omit the fact that there are 4 armor stacks instead of only one? 'Dominus' is, in my opinion, not a good name for the feature, since fewer people know the name of the effect and more people know the name of the crimson armor by now.
The current name looks good
Added new Enchantments, stacking enchantments and formatting for the stacking enchants
Fixed bugs with health when wearing any Crimson armor (Crimson, Terror, Aurora, Fervor) or getting damage by the magama boss
Added Crimson armor Stacks feature
Added new sea creature messages and stacking enchants (thanks @Jani270)
Added option to hide true defense from the action bar (only shown when getting fire damage and not using an ability)
Removed Combat timer (since it's 1 second anyway and was not working before at all)
Removed magma boss timer (since the old boss does not exist anymore)