BiscuitDevelopment / SkyblockAddons

A Minecraft Forge mod with helpful Hypixel skyblock features!
Other
484 stars 238 forks source link

Nether Stuff #641

Closed hannibal002 closed 2 years ago

hannibal002 commented 2 years ago
hannibal002 commented 2 years ago

Made this PR compatible with the current 1.7 release

hannibal002 commented 2 years ago

@ImRodry Please refrain from commenting further on my pull request as you do not seem to have sufficient experience in certain aspects of skyblock, clever phrasing or English spelling, thank you.

ImRodry commented 2 years ago

I’m the localization manager for SBA and you don’t get to tell me when or when not to comment on a PR. If you keep up the attitude I’m closing this PR.

hannibal002 commented 2 years ago

I’m the localization manager for SBA and you don’t get to tell me when or when not to comment on a PR. If you keep up the attitude I’m closing this PR.

My PR has primarily new features and several small fixes, and I don't really want to not merge all the changes because of a name issue. If you can't handle criticism, you shouldn't be on the internet. If you feel better, delete this PR, but I will not continue to discuss with your childish behavior.

hannibal002 commented 2 years ago

And to be clear about another thing: I don't care what your position is in SBA. When you can't communicate respectfully, then I don't respect you either.

ImRodry commented 2 years ago

Suggestions are welcome

jani270 commented 2 years ago

Suggestions are welcome

If you really want to keep this stupid name, please at least add "Show" or "Display" to it

nea89o commented 2 years ago

"Chore: become less of a dick"

nea89o commented 2 years ago

Alright, i take it back, that was a bit rude.

nea89o commented 2 years ago

Oh, also: This doesn't qualify as a chore in my opinion, you should use a different git commit message for that.

ImRodry commented 2 years ago

The commit message is the least relevant thing, the commits will all be squashed anyways

nea89o commented 2 years ago

I'm just saying: if you're gonna nit pick, at least be right while doing so :)

RayDeeUx commented 2 years ago

guys it's called a "dominus"

"Display Dominus"

hannibal002 commented 2 years ago

guys it's called a "dominus"

"Display Dominus"

And the other 3 stacking abilities have the name "Hydra Strike", "Arcane Vision" and "Fervor". So, what now? Add 4 separate features that you have to select manually? Or just omit the fact that there are 4 armor stacks instead of only one? 'Dominus' is, in my opinion, not a good name for the feature, since fewer people know the name of the effect and more people know the name of the crimson armor by now.

ILikePlayingGames commented 2 years ago

The current name looks good