BiscuitDevelopment / SkyblockAddons

A Minecraft Forge mod with helpful Hypixel skyblock features!
Other
484 stars 238 forks source link

[Bug] Trapper cooldown displays the wrong cooldown when Finnegan is not mayor #679

Open Plantterror opened 1 year ago

Plantterror commented 1 year ago

669 was a PR that should not have been accepted, because this behavior of reducing the cooldown of the Trapper in half is only present when Finnegan is mayor. Therefore, we must revert this and check for the current mayor (tab menu? calendar?) before including the reduced cooldown.

To Reproduce

  1. Ensure that Finnegan is not the active mayor.
  2. Enter the Trapper's Den and begin a quest.
  3. Complete the quest in under 60 seconds (wait 30 seconds after accepting if you have hunted the animal before that time).
  4. Note the trapper does not display a timer, indicating that SBA's timer finished, but speaking to the Trapper forces you to wait.

Expected behavior The trapper cooldown was expected to be 60 seconds since Finnegan is not mayor.