BisectStudios / BisectHostingServerIntegrationMenu

BisectHosting Server Integration Menu
4 stars 0 forks source link

[1.18.1] Crash when clicking BH button in top server list #2

Closed ImAK9 closed 2 years ago

ImAK9 commented 2 years ago

https://aofpaste.com/atalebaqiv.yaml

Quarris commented 2 years ago

Which button is that and on which screen?

ImAK9 commented 2 years ago

Screen name is in the log.

Screen name: com.bisecthosting.mods.bhmenu.screens.BHOrderScreen

Crashes when pressing BisectHosting button in server list.

ImAK9 commented 2 years ago

v1.2 works as expected. v1.3 dosen’t

Quarris commented 2 years ago

Can't seem to reproduce it at all. What servers are displayed on your multiplayer screen, do you have more than just the server banner?

ImAK9 commented 2 years ago

I ship 3 servers by default. https://github.com/TeamAOF/All-of-Fabric-5/blob/main/config/builtinservers.json

Quarris commented 2 years ago

Can't seem to find the issue. Currently trying to load it with just fabric and the mod, using the same fabric api version and everything looks fine. I'll look into it tomorrow but I'm afraid it might be a mod compatibility with one of the hundreds of mods in there O.o

Is this a public modpack I can download and try?

image

ImAK9 commented 2 years ago

By all means, grab it here: https://www.curseforge.com/minecraft/modpacks/all-of-fabric-5

ImAK9 commented 2 years ago

I’ll see if I can track it down when on PC, let me know if you find something yourself.

Quarris commented 2 years ago

Sorry for such a late reply. I'm trying to look at the issue so I installed AoF5 - 1.18.2 on CF and it seems to have v1.3 and works fine. Does the issue still persists?

ImAK9 commented 2 years ago

It's still an issue, change order of servers and click button.

https://aofpaste.com/sonuvopura.yaml

ImAK9 commented 2 years ago

This could by all means be a compat issue with the Builtinservers mod.

Quarris commented 2 years ago

I'm trying to figure out how to reproduce this issue. I'm testing this on AOF5 v1.2.2 with mod v1.17.1-1.18.2-1.3 and it seems to work. Are you doing something different to this? https://gyazo.com/04f8e4f3d01f57b65d9ec9b73c3d35de

ImAK9 commented 2 years ago

Could you try manually adding a server with IP “localhost” or whatever on top of the already included ones.

Quarris commented 2 years ago

I've manually added localhost and moved them into every position and it still doesn't give me anything. Let me try to update the pack and see, are you able to maybe show me a gif of how you made it crash?

ImAK9 commented 2 years ago

I've manually added localhost and moved them into every position and it still doesn't give me anything. Let me try to update the pack and see, are you able to maybe show me a gif of how you made it crash?

Will do as soon as I’m home. Also gonna try a couple fresh installs as my dev instance is different in a couple ways.

Quarris commented 2 years ago

Assuming this is fixed. Please re-open if the issue persists