BishopFox / GitGot

Semi-automated, feedback-driven tool to rapidly search through troves of public data on GitHub for sensitive secrets.

GNU Lesser General Public License v3.0

1.43k stars 204 forks source link

Adding Docker Support #11

Closed arcsector closed 5 years ago

arcsector commented 5 years ago

Purpose

ssdeep is a hassle to install on systems and the configuration can take way too long. Using docker, we can run this on a container platform in the cloud or even locally as a service. Logging results is easy with the docker logging driver.

Changes

Adding:

Dockerfile
.gitignore

Changes:

README.md
- Adding docker instructions for building and running
gitgot.py
- Adding fully qualified path to line 288 if user is not running python file from current directory

the-bumble commented 5 years ago

Hi arcsector,

Thank you for your changes! Sorry, I was working on Docker support with another contributor before this submission came in :( Our resulting alpine-based docker image came in at 135MB v.s. this 472MB debian-based image, so we managed to shrink the image-size requirements a bit!

I'm curious for your thoughts on the solution we arrived at. Feel free to send a PR / file an issue if you have any suggested changes/concerns.

Thank you!

arcsector commented 5 years ago

All good; just saw a need and worked to fill it. Only thing i would recommend is to put your dependecies in a directory or a static location; for legacy purposes if the code ever evolves it could break functionality with either python-ssdeep or with ssdeep itself. Regardless, cant wait to see this on dockerhub.

arcsector commented 5 years ago

And side note, the reason i was using debian is because thats what the creator of python-ssdeep is using for his docker container