search

BishopFox / sliver

Adversary Emulation Framework
GNU General Public License v3.0
7.89k stars 1.05k forks source link

Armory update/install is not working as expected #1713

Open Kirasumairu opened 2 weeks ago

Kirasumairu commented 2 weeks ago

Describe the bug Once any subcommand is executed for the Armory module it does not work and always returns errors.

To Reproduce Steps to reproduce the behavior:

  1. Install Sliver following the instructions mentioned in the README.md (curl https://sliver.sh/install|sudo bash)
  2. Execute armory update
  3. Execute armory install rubeus
  4. See error

Expected behavior The armory command should return a successful response once a vaild plugin is supplied as mentioned in the documentation.

Evidence

sliver > armory install sliverkeylogger

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x9d86a6]                                                                                                                

goroutine 23 [running]:
github.com/bishopfox/sliver/client/command/armory.downloadRequest({0x0, 0x0, 0x0, 0xd18c2e2800, 0x0}, {0xc00017e140, 0x4a}, 0x26d9480?)
        github.com/bishopfox/sliver/client/command/armory/parsers.go:439 +0x166
github.com/bishopfox/sliver/client/command/armory.GithubAPIArmoryIndexParser(0x26d9480, {0x0, 0x0, 0x0, 0xd18c2e2800, 0x0})
        github.com/bishopfox/sliver/client/command/armory/parsers.go:225 +0x554
github.com/bishopfox/sliver/client/command/armory.fetchIndex(0x26d9480, {0x0, 0x0, 0x0, 0xd18c2e2800, 0x0}, 0xc00059e9b0?)
        github.com/bishopfox/sliver/client/command/armory/armory.go:427 +0x34e
created by github.com/bishopfox/sliver/client/command/armory.fetchIndexes
        github.com/bishopfox/sliver/client/command/armory/armory.go:382 +0x78

Desktop (please complete the following information):