search

BishopFox / unredacter

Never ever ever use pixelation as a redaction technique
GNU General Public License v3.0
7.66k stars 707 forks source link

Does Not Work on Apple Silicon Macs #4

Open deg4uss3r opened 2 years ago

deg4uss3r commented 2 years ago

Running npm install fails at: 

npm ERR! HTTPError: Response code 404 (Not Found) for https://github.com/electron/electron/releases/download/v9.4.4/electron-v9.4.4-darwin-arm64.zip

Because v9.4.4 does not have an darwin-arm64 build

According to the docs you'll need at least electron 11.0.0.

hfuturer commented 2 years ago

同上更新。在package.json里面electron版本修改为 "electron": "^11.0.1" 就OK啦~

dan-bishopfox commented 2 years ago

I don't have a mac to test on. Does it work if you just roll the electron version up? I'm not quite sure what might break with that upgrade

dropocol commented 2 years ago

Updating the version to 11.0.1 works.

DeEskalator commented 2 years ago

How can I do that?

dropocol commented 2 years ago

@DeEskalator in package.json file, update the electron version to 11.0.1 and run -> npm install

dan-bishopfox commented 2 years ago

I tried out 11.0.1 just now and it looks like it does sub-pixel rendering by default. Which causes the results to have a color to them. I wonder how to turn that off.

DeEskalator commented 2 years ago

@dropocol Thanks man! This fixed it

david-benes commented 9 months ago

I can confirm that electron 11 works on mac silicon. Versions 9 or 10 don't.

bokova commented 7 months ago

Just to add a bit of context, according to https://www.electronjs.org/blog/apple-silicon they Electron has support for M1 Macs (Apple Silicon) added from version 11.0.0-beta.1 upwards.