Bookmak button not recognized under Firefox 29

[GoogleCodeExporter]

I upgraded to Firefox 29 and the setting to show the auto-hidden bookmarks bar 
when hovering the mouse over the bookmark button no longer works.  The setting 
to show the toolbar when hovering over any toolbar *does* work.  I suspect that 
the name of the bookmark button changed since they glued the make-a-bookmark 
and show-bookmarks buttons into one "super button" in Firefox 29.  This is for 
the latest version of the addon (3.3).

Thanks -- Eliot Moss

Original issue reported on code.google.com by jeliotbm...@gmail.com on 3 May 2014 at 8:47

[GoogleCodeExporter]

Here is a patch to chrome/content/browser-overlay.js that fixes the problem;
it does so by matching "bookmarks-menu-button" as well as what it matched
before, in the case of "hovering over a specific button".  This works for
Firefox 29.0 and I don't see any immediate reason why it would affect
operation under earlier Firefox versions.     Eliot Moss

*** browser-overlay.js.old  2012-06-05 12:11:22.000000000 -0400
--- browser-overlay.js  2014-05-09 13:18:07.183354500 -0400
***************
*** 261,270 ****
--- 261,271 ----
        var hoverItems =
        [
            [ /* button only */
                document.getElementById("hidebookmarksbarButton"),
                document.getElementById("bookmarks-menu-button-container"),
+               document.getElementById("bookmarks-menu-button"),
                document.getElementById("bookmarks-button")
            ],
            [ /* any toolbar */
                toolbox
            ]

Original comment by jeliotbm...@gmail.com on 9 May 2014 at 6:23