Bismuth-Forge / bismuth

KDE Plasma add-on, that tiles your windows automatically and lets you manage them via keyboard, similarly to i3, Sway or dwm.
https://bismuth-forge.github.io/bismuth/
Other
2.41k stars 93 forks source link

[Bug]: Problem removing keyboard shortcuts after uninstall #137

Open nivaca opened 2 years ago

nivaca commented 2 years ago

Summary

I uninstalled Bismuth using the supplied uninstaller (in the source archive). It correctly uninstalled Bismuth but left all the keyboard bindings (in System Settings -> Shortcuts -> Kwin). How can I remove them?

Steps to Reproduce

  1. Install Bismuth using the supplied installer in the archive: npm run script-install
  2. Uninstall it now: npm run script-uninstall

I get the following confirmation:

> bismuth@1.1.0 script-uninstall
> bin/uninstall.sh

Successfully uninstalled 

However, the keybindings are still left.

Expected behavior

The keybindings should disappear after uninstall.

Screenshots

2021-10-27_09-12

Bismuth version

1.1.0

KDE Plasma version

5.22.5

The platform KWin is running on

X11

Additional context

No response

gikari commented 2 years ago

I am not sure baking the shortcuts' removal into the uninstallation is a good idea. What if the user wants to preserve the shortcuts to reinstall the software?

What could be done is a separate script in contrib/, that removes shortcuts.

You can also do it manually by deleting entries in the ~/.config/kglobalshortcutsrc starting with bismuth_ and the reloading the shortcut daemon (not sure what the name is. Once I found out, I can fix #90 and #96 ).

nivaca commented 2 years ago

You're right about the user's wanting to keep the shortcuts, but that may also be an option. I just created a script for that and made a pull request.

fourteenminusone commented 2 years ago

Hi,

I manually edited kglobalshortcutsrc file removimg all bismuth entries, but GUI entries in kWin menu still remain. After rebooting also kglobalshortcutsrc turns to contain bismuth entries.

Could you check please?

EDIT:

I found a solution for the problem in subject:

This way, Bismuth shortcuts entries will disappear from Settings menu and even after restarting the session and it seems that the settings are really saved and loaded correctly.

References https://www.reddit.com/r/kde/comments/e2ew10/reload_global_shortcuts_config/ https://www.reddit.com/r/kde/comments/6u0wo7/configuring_kde_by_editing_the_config_files/dlqzeop/