Bisonai / orakl

Official Oracle of Kaia Blockchain
https://orakl.network
MIT License
69 stars 13 forks source link

(OraklNode) Update bybit v2 to v5 #1704

Closed nick-bisonai closed 1 week ago

nick-bisonai commented 1 week ago

Description

Migrate from V2 api to V5 api

Type of change

Please delete options that are not relevant.

Checklist before requesting a review

Deployment

coderabbitai[bot] commented 1 week ago

[!WARNING]

Rate limit exceeded

@nick-bisonai has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 21 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 3914e37bf535fa6bbe0390a3c05d8839e03311f4 and a4025729df661e829c3b7b73f4f4c3b2125412d7.

Walkthrough

The recent changes enhance the Bybit WebSocket fetcher by modifying the data handling, updating constants, and adding new functionalities like a periodic ping to the Bybit server. Files across the Bybit package, including bybit.go, type.go, utils.go, and the main testing script, have been updated to reflect these improvements and to ensure consistency.

Changes

Files Summary
node/pkg/websocketfetcher/providers/bybit/bybit.go Added import for time, increased loop increment from 3 to 10, updated handleMessage condition, added ping function.
node/pkg/websocketfetcher/providers/bybit/type.go Updated URL constant, modified Response struct, added Heartbeat struct.
node/pkg/websocketfetcher/providers/bybit/utils.go Adjusted handling of timestamp, price, and volume data, improved error handling in ResponseToFeedData function.
node/script/test_websocketFetcher/main.go Replaced coinbase with bybit for WebSocket configurations, introduced a channel for common.FeedData, updated error logging.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BybitFetcher
    participant BybitServer

    User ->> BybitFetcher: Initialize BybitFetcher
    BybitFetcher ->> BybitServer: Send WebSocket Connect Request
    BybitServer -->> BybitFetcher: Respond with WebSocket Connection

    loop Every 10 Messages
        BybitFetcher ->> BybitServer: Send Ping Message
    end

    BybitServer -->> BybitFetcher: Send Topic Data
    BybitFetcher -->> BybitFetcher: Check Topic Data

    BybitFetcher -->> User: Update FeedData Channel
    User ->> BybitFetcher: Handle Feed Data

Poem

In the world of bytes and bits, A bunny hops with joyous fits. Bybit pings and data flows, Through webs and streams it swiftly goes. Prices chart the volume high, Hopping forward, reaching sky. Code refined and errors few, Oh the wonders, we see anew! 🌟🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.