Closed nick-bisonai closed 1 week ago
[!WARNING]
Rate limit exceeded
@nick-bisonai has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 21 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 3914e37bf535fa6bbe0390a3c05d8839e03311f4 and a4025729df661e829c3b7b73f4f4c3b2125412d7.
The recent changes enhance the Bybit WebSocket fetcher by modifying the data handling, updating constants, and adding new functionalities like a periodic ping to the Bybit server. Files across the Bybit package, including bybit.go
, type.go
, utils.go
, and the main testing script, have been updated to reflect these improvements and to ensure consistency.
Files | Summary |
---|---|
node/pkg/websocketfetcher/providers/bybit/bybit.go |
Added import for time , increased loop increment from 3 to 10, updated handleMessage condition, added ping function. |
node/pkg/websocketfetcher/providers/bybit/type.go |
Updated URL constant, modified Response struct, added Heartbeat struct. |
node/pkg/websocketfetcher/providers/bybit/utils.go |
Adjusted handling of timestamp, price, and volume data, improved error handling in ResponseToFeedData function. |
node/script/test_websocketFetcher/main.go |
Replaced coinbase with bybit for WebSocket configurations, introduced a channel for common.FeedData , updated error logging. |
sequenceDiagram
participant User
participant BybitFetcher
participant BybitServer
User ->> BybitFetcher: Initialize BybitFetcher
BybitFetcher ->> BybitServer: Send WebSocket Connect Request
BybitServer -->> BybitFetcher: Respond with WebSocket Connection
loop Every 10 Messages
BybitFetcher ->> BybitServer: Send Ping Message
end
BybitServer -->> BybitFetcher: Send Topic Data
BybitFetcher -->> BybitFetcher: Check Topic Data
BybitFetcher -->> User: Update FeedData Channel
User ->> BybitFetcher: Handle Feed Data
In the world of bytes and bits, A bunny hops with joyous fits. Bybit pings and data flows, Through webs and streams it swiftly goes. Prices chart the volume high, Hopping forward, reaching sky. Code refined and errors few, Oh the wonders, we see anew! 🌟🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
Migrate from V2 api to V5 api
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment