Bisonai / orakl

Official Oracle of Kaia Blockchain
https://orakl.network
MIT License
69 stars 13 forks source link

(OraklNode) Bulk insert local aggregation #1726

Closed Intizar-T closed 5 days ago

Intizar-T commented 5 days ago

Description

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Checklist before requesting a review

Deployment

coderabbitai[bot] commented 5 days ago

[!WARNING]

Rate limit exceeded

@Intizar-T has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 58 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 24f9042535d00e24309b2de7ff129bc9951208ba and a4edba97ccf748dea295d6bfdd64a252614cdadd.

Walkthrough

The node/pkg/fetcher package was enhanced with the addition of constants, new functions, and adjustments to existing components, primarily to improve handling of local aggregates and accumulator functionality. New types, functions for processing aggregates, and updates to collectors and tests ensure more efficient data processing, aggregation, and storage mechanisms within the application.

Changes

File Summary
node/pkg/fetcher/app.go Added constants for channel size and interval, new startAccumulator function, and updated initialize to set up the accumulator channel and initialize the accumulator.
node/pkg/fetcher/app_test.go Added DUMMY_FEED_VALUE constant and TestLocalAggregatesChannel function to test the new channel and accumulator logic.
node/pkg/fetcher/collector.go Updated NewCollector to include localAggregatesChannel parameter and modified insertAggregateData method.
node/pkg/fetcher/types.go Introduced LocalAggregate type and added localAggregatesChannel field to App struct.
node/pkg/fetcher/accumulator.go Introduced new Accumulator struct and methods for running accumulator jobs.
node/pkg/fetcher/accumulator_test.go Added tests for the new accumulator functionality to ensure data is processed and stored correctly.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant App
    participant Collector
    participant Accumulator
    participant Redis
    participant PostgreSQL

    Client->>App: initialize()
    App->>App: startAccumulator()
    App->>Collector: newCollector(localAggregatesChannel)
    Collector->>Accumulator: send(LocalAggregate)
    Accumulator->>Accumulator: Run()
    Accumulator->>Redis: bulkStoreLocalAggregates()
    Accumulator->>PostgreSQL: bulkStoreLocalAggregates()

Poem

New changes in code, oh what a sight,
Aggregates now flow day and night.
Channels tuned and tests are primed,
In the fetcher, everything's aligned.
🐇 With hops of joy, the rabbit cheers,
For the code is built, free of fears! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Intizar-T commented 5 days ago

it is optional, but I'd recommend you to write separate file for bulk insertion rather than adding the functionality into app.go file. because initial intention for app.go was for high level application which only cares about controlling other internal applications rather than having its own job implementations.

good point, I was thinking about this as well. Will move to a separate file