search

Bisonai / orakl

Official Oracle of Kaia Blockchain
https://orakl.network
MIT License
71 stars 16 forks source link

How to decide `minSubmissionValue` and `maxSubmissionValue`? #90

Closed martinkersner closed 1 year ago

KelvinThai commented 1 year ago

These 2 parameters set the boundary for off-chain oracles when they submit results to on-chain aggregator. The value should be set depending on what kind of data is being submitted. Eg. For stable coin price, the price can fluctuate but can not be 2 $/stabelcoin. Chainlink marks this as immutable, we can not change it after initialization. For our current adapter which is KLAY/USD. we can set that from 1 to the biggest of it datatype. who knows what the price can be in the future.

martinkersner commented 1 year ago

Thank you! Let me think about this until tomorrow and we can have a call make decision tomorrow!

martinkersner commented 1 year ago

After discussion with Kelvin, we decided to remove minSubmissionValue and maxSubmissionValue from Aggregator for now. However, we understand the need for checking submitted values. We will keep thinking about this problem and try to come up with a better solution than hardcoded immutable constants.

cc @KelvinThai @bayram98