search

Bit-Nation / BITNATION-Pangea-mobile

Pangea iOS and Android repository
MIT License
52 stars 13 forks source link

When verifying/entering recovery seed of new wallet, please trim the text box input strings #316

Closed marknuzz closed 6 years ago

marknuzz commented 6 years ago

Feature / Issue

This occurs when verifying the recovery seed of a new wallet. When clicking a box to type in, there is often a trailing space character. This can cause the app to think that the recovery seed is wrong. This should be done on both the verification, and the actual recovery process. Use the string trim function to remove leading and trailing whitespace.

Additional information

I am using a Samsung Galaxy Note 4, Android 6.0.1.

florianlenz commented 6 years ago

@swmd would you mind to fix this? For the next release it's ok to just remove the white spaces when sending the mnemonic to the pangea lib's function. Another point, could you pleas make sure that all work's are transformed to lower case? All words from bip32 are lowercase, so we can just make sure that they are all lowercase, in case someone enters "House" instead of "house".

swmd commented 6 years ago

@florianlenz I guess that this issue has been fixed already. I have tested with the latest version and could not reproduce the issue.

seland commented 6 years ago

Yes, it was fixed in 0.4.0. Closing the issue.