search

Bit-Nation / BITNATION-Pangea-react

Pangea Jurisdiction Alpha client v. 03 frontend repository
MIT License
7 stars 5 forks source link

[Tests] Add better test code coverage #21

Closed dcfranca closed 6 years ago

dcfranca commented 7 years ago

Increase the percentage of code covered by tests.

florianlenz commented 7 years ago

@danielfranca I merged the PR. Can you please check if that satisfy your requirement's so that we can close this issue. Thx.

dcfranca commented 7 years ago

Actually what I meant with this issue is to improve the code coverage itself (testing more parts of the code that at the moment are not reachable by the current tests)

jetpack3331 commented 7 years ago

@danielfranca working on it. I misunderstood the title...

jetpack3331 commented 7 years ago

@danielfranca Any progress with that? I'm trying to solve the problem, but without luck...

florianlenz commented 7 years ago

I can't reproduce it too. @danielfranca Maybe we can just close it and if it's still present we will reopen it.

Pushplaybang commented 7 years ago

👍 absolutely, though it's a nice side effect to have the coverage setup @jetpack3331

jetpack3331 commented 7 years ago

Did test for components, containers and rewrite some code Added npm command for test coverage

In future we should make test for redux, but i think it's not unnecessary for now

@danielfranca If it's ok, then we can close it

jetpack3331 commented 6 years ago

There is running PR https://github.com/Bit-Nation/BITNATION-Pangea-react/pull/30