search

Bit-Quill / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
0 stars 0 forks source link

Does exporter need to support non-sso schema? #1

Open MaxKsyunz opened 1 year ago

MaxKsyunz commented 1 year ago

By default, opensearch-exporter sends signals in an otel-like schema.

Do we need to keep it? The differences between default schema and SSO are minor however it only maps a subset of opentelemetry data.

MaxKsyunz commented 1 year ago

@YANG-DB @derek-ho What do you think? Do we need to support the implicit schema we inherited?

I'm in favour of removing it.

derek-ho commented 1 year ago

My concern with removing it is whether there is some concept of lock-in that people may be afraid of if they use the opensearch exporter - if it's getting mapped to SSO schema with no option to back out... Maybe they will want to move their data to other platforms/agents/whatever that works well with OTEL but doesn't know about SSO, what do you folks think? I am not sure how many people are looking to move data out, but just raising that concern here

MaxKsyunz commented 1 year ago

@derek-ho fair point.

I had a look and it's fairly straight-forward to send data in Otel schema -- there's a JSON marshaller. It's not obvious why elastic exporter didn't just use that.

YANG-DB commented 1 year ago

we can offer both - use configuration to allow choosing if sso option selected - data is written to default indices if non-sso option selected - user need to specify index name to write into