search

Bit-Wasp / secp256k1-php

PHP bindings for bitcoin-core/secp256k1
The Unlicense
57 stars 37 forks source link

Add valgrind run to CI #139

Open afk11 opened 5 years ago

afk11 commented 5 years ago

as mentioned in https://github.com/Bit-Wasp/secp256k1-php/issues/131, we should have travis run valgrind tests.

recently I've done some work on this using a php build from source with the following: ./buildconf && ./configure --with-valgrind --with-pcre-valgrind --with-secp256k1 && make -j8

with the projects secp256k1 dir located in ./ext/secp256k1 and then using the following to run valgrind tests: make test TESTS="./ext/secp256k1/tests -m"

ideally we'd be able to run this on multiple php versions - maybe several Docker files in phpqa?

afk11 commented 5 years ago

seems a debug build of php mightn't be necessary (for simply testing for issues anyway), so travis' php should be suitable.