BitBagCommerce / SyliusCmsPlugin

Content management system for eCommerce apps created on Sylius platform. Built with Sylius code quality, flexibility, BDD.
MIT License
235 stars 159 forks source link

Sitemap support #41

Closed stefandoorn closed 6 years ago

stefandoorn commented 7 years ago

Sylius Sitemap Plugin exists: https://github.com/stefandoorn/sitemap-plugin. Would be great to have a provider to include the page URL's into it.

Some options:

@bitbager What do you prefer?

bitbager commented 7 years ago

Hmm, I think that generic sitemap provider functionality can be added to the plugin and an extra plugin for it would be too much. Would it be possible to write a sitemap processor and add the sitemap extension installation guide to the README file?

stefandoorn commented 7 years ago

If we put it behind a config setting, then we can dynamically load the service definition that includes the sitemap provider (which gives the URL's to the sitemap plugin). In that case the plugin also doesn't crash if users do not load the sitemap plugin.

It would be weird to include it as requirement, as users then automatically get a sitemap also for products/taxons, etc. (not configurable yet). So it would be good to really activate it I think. WDYT about this?

bitbager commented 7 years ago

Yeap, looks like it would require another plugin. But it should not be hard to develop.

stefandoorn commented 7 years ago

Ok. I'll see if I can get it working inside the plugin first, else I'll go for a separate package.

bitbager commented 7 years ago

Perfect! Let me know once you make some progress 🙂

bitbager commented 6 years ago

@stefandoorn, any news? 🙂