Remove unneeded FOSRest extension, use AbstractController

BitBagCommerce / SyliusMailChimpPlugin

Simple MailChimp integration with Sylius eCommerce framework.

MIT License

42 stars 27 forks source link

Remove unneeded FOSRest extension, use AbstractController #38

Closed jordisala1991 closed 3 years ago

jordisala1991 commented 3 years ago

The dependency is not declared on composer.json, that makes compatibility with Sylius 1.9 impossible, because on Sylius 1.9 you need to use fos-rest 3.0 which does not have FOSRestController , but AbstractFOSRestController...

I think this controller does not use anything special to need to extend FOSRestController, we can use AbstractController.

jordisala1991 commented 3 years ago

friendly-ping @patrick477 this build is not easily fixable, it needs a full replacement for github actions.

tbuczen commented 3 years ago

This has been resolved in https://github.com/BitBagCommerce/SyliusMailChimpPlugin/pull/39