Is there any planned upgrade?

spyesx commented 1 year ago

What is your question / Please describe your issue

Hi,

I went to read the packages/theme/package.json and most of the packages are outdated for a while.

I'd like to know if this project is maintained by its developers or not? Is there any planned upgrade somewhere? Maybe I can help as well.

Thx :)

What version of Sylius Integration are you using?

1.12.7

Code of Conduct

[X] I agree to follow this project's Code of Conduct

dead-playmod commented 1 year ago

Hey @spyesx.

I'd like to know if this project is maintained by its developers or not?

Yes, we are still maintaining this project.

Is there any planned upgrade somewhere?

We weren't really planning any updates at the moment, but we could do some updating depending on which packages you meant. If you could send a list of packages you'd like to be updated, we could talk a bit more about it.

spyesx commented 1 year ago

Hi :)

Well, back in April, a npm audit would return a lot of deprecated modules. I wanted to show the result but I got something different today.


➜  SyliusVueStorefront2Frontend git:(main) npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: @vue-storefront/sylius-theme@1.0.2
npm ERR! Found: @nuxt/types@0.7.9
npm ERR! node_modules/@nuxt/types
npm ERR!   dev @nuxt/types@"^0.7.9" from @vue-storefront/sylius-theme@1.0.2
npm ERR!   packages/theme
npm ERR!     @vue-storefront/sylius-theme@1.0.2
npm ERR!     node_modules/@vue-storefront/sylius-theme
npm ERR!       workspace packages/theme from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @nuxt/types@">=2.13.1" from @nuxt/typescript-build@2.1.0
npm ERR! node_modules/@nuxt/typescript-build
npm ERR!   dev @nuxt/typescript-build@"^2.0.0" from @vue-storefront/sylius-theme@1.0.2
npm ERR!   packages/theme
npm ERR!     @vue-storefront/sylius-theme@1.0.2
npm ERR!     node_modules/@vue-storefront/sylius-theme
npm ERR!       workspace packages/theme from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/spyesx/.npm/_logs/2023-06-19T10_06_43_958Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/spyesx/.npm/_logs/2023-06-19T10_06_43_958Z-debug-0.log

What do you think?

dead-playmod commented 1 year ago

Hey @spyesx, could you run it with yarn instead of npm. This project is setup to work with yarn and uses yarn workspaces under the hood.

Coming back to upgrades, we will probably do a bigger package upgrade at some point, but it would be a bigger overhaul and we'd like to do it all in one bigger patch.

For now I did see a lot of critical and high vulnerabilities after audit, so we will probably have to speed it up a bit.

spyesx commented 1 year ago

Great :) Thx for the news.

BitBagCommerce / SyliusVueStorefront2Frontend