search

BitBotFactory / MikaLendingBot

Automated lending on Cryptocurrency exchanges Poloniex and Bitfinex
http://poloniexlendingbot.readthedocs.io/en/latest/index.html
MIT License
1.11k stars 344 forks source link

[Feature Request] Support for Bitfinex #154

Closed HostFat closed 7 years ago

HostFat commented 7 years ago

Currently this seems the only bot where the developing is going on.

I'm using both exchanges, and maybe even others will like to use this bot for Bitfinex.

Evanito commented 7 years ago

@HostFat [Remake Request]?

1) The bot is named Poloniex, adding an extra exchange would require a rename.

2) The two APIs are incompatible and would require rewriting much of bot.

3) Are the rates better on Bitfinex to justify the effort of adding it?

4) Bitfinex was hacked on August 2nd, 2016.

That is my 5 minute summary against, what do you say in favor?

HostFat commented 7 years ago

  1. I think that you can change the name in something more general, so being able to support Bitfinex and any other future exchanges that will give access to lending.

  2. I know, but I think that the most important thing of the bot is the logic on its acting on the market (whatever market) Maybe this can be done by someone else if you have no time :) (you will have to accept the PR)

  3. This is it currently: https://imgur.com/a/xzAai

  4. As Poloniex, but it changed a lot from that time: http://www.coindesk.com/poloniex-loses-12-3-bitcoins-latest-bitcoin-exchange-hack/

  5. Maybe, just maybe, supporting more exchanges will give to the project better chances to receive donations.

Evanito commented 7 years ago

Okay, Raanan and I will discuss it. We have been considering getting a unique name to separate us from the unaffiliated website of the same name.

Evanito commented 7 years ago

I plan on using a module to transform the Bitfinex API response to something the bot can read, thus adding compatibility.

That said, this is not high on our priority list, we want to add features that benefit the majority of our users who use Poloniex.

rnevet commented 7 years ago

I agree with Evan, from a short search I couldn't find a full Python implementation of the Bitfinex api, what I found so far is: https://github.com/scottjbarr/bitfinex/blob/develop/bitfinex/client.py (only lend book implemented) https://github.com/streblo/bitfinex-python-client/blob/master/bitfinex/client.py (no loan implemetation) Both seem not maintained.

I would say this will be a big effort.

HostFat commented 7 years ago

There is also this, but I think that it's old: https://github.com/ah3dce/cascadebot/blob/master/cascadebot.py

Jed7 commented 7 years ago

Hello There, Currently, the BTC lending rates are better on Poloniex, BUT there's way more volume on other cryptos (ETH, Zcash, Monero, ....) and you can even lend USD. I think it would be interesting to apply some diversification on our capital. (Sorry for my bad Frenchglish)

JCBauza commented 7 years ago

I am in favor as well for Bitfinex support. It is not critical for me as I already use FFR but it would definitively be an improvement. Bitfinex has great ZCash and USDT rates right now.

shevah commented 7 years ago

Same here, something strange is going on in poloniex. The support team isn't functioning. I guess we will see a drift toward other exchanges.

Bitfinex are developing API V2, it worth to check if we can bridge the APIs.

SPIRY-RO commented 7 years ago

Somebody seems is already working on it in its spare time. Maybe if some developer can pick it up?? https://github.com/mahiso/poloniexlendingbot/tree/bitfinex

rnevet commented 7 years ago

The devs here are also maintaining the bot on their spare time. It would be great to see a PR from @mahiso when his change is ready.

SPIRY-RO commented 7 years ago

Oh I am sure of that. I am even at disposal to help with a group donation if somebody is in for it. I mean well I really need it like a necessity lol.

mahiso commented 7 years ago

Hi, I work on it and it is to 90% ready....but the ninety-ninety-rule....

SPIRY-RO commented 7 years ago

Awesome!! I'll test it out a bit later I am curious as hell to see if it works . I am using coinlend.de so far for Bitfinex. But I want most of the lending data I have to centralize it.

2017-07-24 21:41 GMT+03:00 Maik Hinrichs notifications@github.com:

Hi, I work on it and it is to 90% ready....but the ninety-ninety-rule....

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BitBotFactory/poloniexlendingbot/issues/154#issuecomment-317516371, or mute the thread https://github.com/notifications/unsubscribe-auth/AFwaLLjSB7F1HaFjy_bfFW5B-pDoCivOks5sROU_gaJpZM4LDNRw .

SPIRY-RO commented 7 years ago

@mahiso I've just run it and I have this

2017-07-25 13:16:39 Error: API Error 400: {"message":"Nonce is too small."} Requesting https://api.bitfinex.com/v1/offers

mahiso commented 7 years ago

Please create a new API key on Bitfinex. The nonce in one request must always be greater than the nonce in last request. Therefore it is not possible to use one API key in more than one application.

mchl18 commented 7 years ago

I myself have been thinking about a general multi-trading-lending bot which could integrate the numerous bots and apis under one hood. Standardizing each lib and so on. I have started with bitttrex and polo, but for trading, not lending and also only the JS wrappers. If I find some people who are willing to work on that, it could fit into the picture. Thing is, I am a quite a newbie.

Evanito commented 7 years ago

Should have closed as #435 is merged.