search

BitBoxSwiss / bitbox-api-rs

BitBox02 client library for Rust and TypeScript
Apache License 2.0
5 stars 9 forks source link

src: BTC sign message implemented and tested #53

Closed asi345 closed 11 months ago

asi345 commented 11 months ago

Addresses the request in the issue : #49

The implementation of BTC message signing has been completed and it also supports antiklepto verification. Furthermore, a test is added as an example in 'examples' folder.

benma commented 11 months ago

src: BTC sign message implemented and tested

may I propose a better title? src as context does not say much, almost any change will be in src.

btc: add btc_sign_message() and example

it is shorter, and tested does not mean much if there is no unit test. also generally in commit titles it is better to use the imperative form (e.g. add instead of added) for brevity.

asi345 commented 11 months ago

I implemented the requested changes and now pushing a new commit according to them

asi345 commented 11 months ago

Okay, I updated the code, adjusting according to your review