frontend/coin-control: add address reuse warning

BitBoxSwiss / bitbox-wallet-app

The BitBoxApp for desktop and mobile.

https://bitbox.swiss/app

Apache License 2.0

251 stars 82 forks source link

frontend/coin-control: add address reuse warning #2724

Closed strmci closed 2 months ago

strmci commented 3 months ago

Add a warning to the coin control modal when a user selects one or more UTXOs from reused addresses. The warning: "One or more UTXOs have a reused address. Be aware the receiver will see all UTXOs associated with those addresses."

The UTXOs now have red badge when their address was re-used.

strmci commented 3 months ago

@Beerosagos @thisconnect

fixed the repeated warning for each UTXO's script type
the warning is shown only when the user selects the UTXO from the reused address
I changed the warning from Status to Message so it is not all red
added a badge to all UTXOs from re-used addresses
CHANGELOG updated

PTAL

thisconnect commented 3 months ago

Nit: maybe we can vertically center better the badge?

I'll take a look, ideally badge would be nice and inline with text. Not sure yet what causes this.

thisconnect commented 3 months ago

I'll take a look, ideally badge would be nice and inline with text. Not sure yet what causes this.

tl;dr it was a combination of inconsitent line-heights (parent element) and vertical centering.

branch with fix https://github.com/thisconnect/bitbox-wallet-app/tree/frontend-fix-badge-centering

diff https://github.com/BitBoxSwiss/bitbox-wallet-app/compare/master...thisconnect:frontend-fix-badge-centering?expand=1

@strmci @Beerosagos let me know if you want to merge this PR first and if I should open a followup PR or feel free to chery-pick my commit into this change.

strmci commented 2 months ago

@thisconnect I cherry-picked your Badge improvement, thanks.