backend/coin balance: refactor total coin balance calculation

BitBoxSwiss / bitbox-wallet-app

The BitBoxApp for desktop and mobile.

https://bitbox.swiss/app

Apache License 2.0

251 stars 82 forks source link

backend/coin balance: refactor total coin balance calculation #2736

Closed strmci closed 2 months ago

strmci commented 2 months ago

The backend now returns a slice of coin balances including coin names and correct sorting, removing the need to fetch account data on the frontend.

strmci commented 2 months ago

@NicolaLS thanks for the review, I made the suggested changes.

NicolaLS commented 2 months ago

tested (webdev & AppImage) LGTM.

thisconnect commented 2 months ago

there is some overlap with https://github.com/BitBoxSwiss/bitbox-wallet-app/pull/2733 in which the duplicate getAccountsPerCoin function is moved to utils. This PR removes 1 of the 2 getAccountsPerCoin functions. The other one is in SummaryBalance.

strmci commented 2 months ago

@Beerosagos thanks, PTAL