Frontend fix css regression

BitBoxSwiss / bitbox-wallet-app

The BitBoxApp for desktop and mobile.

https://bitbox.swiss/app

Apache License 2.0

251 stars 82 forks source link

Frontend fix css regression #2743

Closed thisconnect closed 2 months ago

NicolaLS commented 2 months ago

tested AppImage LGTM!

Sidebar scroll works
Pocket and Moonpay show properly now

edit: PR fixes described problem, but there seem to be more e.g. webdev unlock software keystore modal/dialog. I wonder if there is some method to find all of those issues instead of finding them by trial and error

thisconnect commented 2 months ago

added a commit that should fix:

height not expanding to full height when the content is smaller than the window height
dialogs always using full height

what to test:

waiting view
dialog i.e. enable tor proxy
bootloader view (using centeredcontent comp)

NicolaLS commented 2 months ago

tested webdev firefox (BB02B and software keystore), AppImage on linux and the android app. the problem with the dialog expanding is fixed, not sure what the issue with bootloader view and waiting view was but they looked normal to me too.

shonsirsha commented 2 months ago

Tested on Chrome webdev macOS. Seems to fix the regressions. 👍

blv

bbtc

password