BitBoxSwiss / bitbox-wallet-app

The BitBoxApp for desktop and mobile.
https://bitbox.swiss/app
Apache License 2.0
245 stars 82 forks source link

frontend: bump react dep. version to 18.3.1 #2750

Closed NicolaLS closed 1 month ago

NicolaLS commented 1 month ago

All other dependencies support at least ^18.0.0 in their peer dependency list:


[sus@archlinux web]$ npm ls react
bitboxapp@0.0.0 /home/sus/Work/bitbox/dev/bitbox-wallet-app/frontends/web
├─┬ @testing-library/react@14.3.1
│ └── react@18.2.0 deduped
├─┬ react-dom@18.2.0
│ └── react@18.2.0 deduped
├─┬ react-i18next@11.16.8
│ └── react@18.2.0 deduped
├─┬ react-router-dom@6.4.3
│ ├─┬ react-router@6.4.3
│ │ └── react@18.2.0 deduped
│ └── react@18.2.0 deduped
├─┬ react-select@5.8.0
│ ├─┬ @emotion/react@11.11.4
│ │ ├─┬ @emotion/use-insertion-effect-with-fallbacks@1.0.1
│ │ │ └── react@18.2.0 deduped
│ │ └── react@18.2.0 deduped
│ ├─┬ react-transition-group@4.4.5
│ │ └── react@18.2.0 deduped
│ ├── react@18.2.0 deduped
│ └─┬ use-isomorphic-layout-effect@1.1.2
│   └── react@18.2.0 deduped
└── react@18.2.0

[sus@archlinux web]$ cat node_modules/react-select/package.json | grep peerDependencies -A 5
  "peerDependencies": {
    "react": "^16.8.0 || ^17.0.0 || ^18.0.0",
    "react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0"
  },
  "files": [
    "dist",
[sus@archlinux web]$ cat node_modules/react-router-dom/package.json | grep peerDependencies -A 5
  "peerDependencies": {
    "react": ">=16.8",
    "react-dom": ">=16.8"
  },
  "files": [
    "dist/",
[sus@archlinux web]$ cat node_modules/react-i18next/package.json | grep peerDependencies -A 5
  "peerDependencies": {
    "i18next": ">= 19.0.0",
    "react": ">= 16.8.0"
  },
  "peerDependenciesMeta": {
    "react-dom": {
      "optional": true
    },
    "react-native": {
      "optional": true
[sus@archlinux web]$ cat node_modules/react-dom/package.json | grep peerDependencies -A 5
  "peerDependencies": {
    "react": "^18.2.0"
  },
  "files": [
    "LICENSE",
    "README.md",
``
NicolaLS commented 1 month ago

tested on webdev firefox

thisconnect commented 1 month ago

please update react and react-dom together in same commit.

NicolaLS commented 1 month ago

Squashed the commits in #2751