search

BitBoxSwiss / bitbox-wallet-app

The BitBoxApp for desktop and mobile.
https://bitbox.swiss/app
Apache License 2.0
245 stars 82 forks source link

chore(deps): update go to 1.21 #2756

Closed baizon closed 1 month ago

baizon commented 1 month ago

Update to Go 1.21. Steps to reproduce:

  1. go mod edit -go 1.21
  2. go mod tidy
  3. Manually edited: .github/workflows/ci.yml -> go-version: 1.21.x and appveyor.yml -> GOROOT: C:\go121
  4. git commit
  5. go get -u ./...
  6. go mod tidy
  7. go mod vendor
  8. git commit & git push
benma commented 1 month ago

By the way, Go was updated to 1.21 already in https://github.com/BitBoxSwiss/bitbox-wallet-app/commit/50c164cab4d0abdd49adfab92091058971ffe3f6, but you have found a few places where the number was not updated properly in https://github.com/BitBoxSwiss/bitbox-wallet-app/pull/2754, so that's nice!

In any case, as I mentioned in the other PR, please split the Go 1.21 fixes into a separate commit - this one seems to contain all the deps update stuff too.

Thanks!

baizon commented 1 month ago

I did a spit now. 2 commits, 1 with the Go update and the second one with the dependencies. I hope this time it's fine.

benma commented 1 month ago

By the way, Go 1.22 is out too, and finally fixes the reference sharing in for loops:

https://go.dev/doc/go1.22

Would you be willing to make a (separate) PR to update to Go1.22? If you open the PR, I can make and push a new image based on it.

thisconnect commented 1 month ago

The instructions to reproduce this PR are amazing and made review a breeze. I got the same diff ❤️

ack to copy the instructions and document in the README?

benma commented 1 month ago

@thisconnect maybe not necessary anymore with https://github.com/BitBoxSwiss/bitbox-wallet-app/pull/2752, which will open PRs to bump deps automatically. You can consider extending this to handle the frontend deps too.