search

BitBoxSwiss / bitbox-wallet-app

The BitBoxApp for desktop and mobile.
https://bitbox.swiss/app
Apache License 2.0
245 stars 82 forks source link

frontend: improve translations with crypto, bitcoin or coincode #2790

Closed thisconnect closed 1 week ago

thisconnect commented 1 week ago

In some languages Bitcoin or crypto can have special ending depending on the context, so translating crypto does not work in all cases.

Added Bitcoin and crypto context with option to show coinCode, if needed.

The buy title will now use coin code instead of coinname, this is so that we do not need a different translation key for each altcoin. With that the buy workflow can show 'Buy Bitcoin' or 'Buy crypto', and once an account is selected it will show the coin code of the altcoin (unless it is Bitcoin), i.e. 'Buy LTC'.

For simplicity the guide is just using crypto or bitcoin. Also buy.info.disclaimer keys need to be updated with coinCode.

Related https://github.com/BitBoxSwiss/bitbox-wallet-app/commit/b617b15427ffac7e0c0e9e1b7c2a8d01b59cefd0

thisconnect commented 1 week ago

CI isn't happy that I renamed the keys, this is expected and good that it reports this.